Ticket #2 (closed defect: fixed)

Opened 21 months ago

Last modified 21 months ago

All div's media_1 when including multiple videos

Reported by: human Owned by: buzz
Priority: critical Milestone:
Component: wordpress-flowplayer Version:
Keywords: Cc: tom@…

Description

Hi David,

I found another bug. If you have more than 1 video on the main page they are all
in different div with the _same_ name : media_1. And they will all be the first
video (oldest) of your main page.
You could try a md5sum or a base64 of the name, for the moment I've done an
awful hack strlen($media) just to be sure that was the problem...

Cheers,
Thomas

Change History

  Changed 21 months ago by buzz

  • status changed from new to accepted

in reply to: ↑ description   Changed 21 months ago by buzz

To clarify, this bug only occurs on a page with multiple posts, on a single post for instance you may include an number of videos, unfortunately the

add_filter('the_content', 'flowplayer_content');

hook is called per post, as such a multi post page will always start as media_1.

As suggested by Thomas a workaround is to provide a hash of the file being played itself, however this will fail in the event two posts on the same page share the same media file.

I will update this ticket once I have found a work around.

Replying to buzz:

Hi David,

I found another bug. If you have more than 1 video on the main page they are all
in different div with the _same_ name : media_1. And they will all be the first
video (oldest) of your main page.
You could try a md5sum or a base64 of the name, for the moment I've done an
awful hack strlen($media) just to be sure that was the problem...

Cheers,
Thomas

  Changed 21 months ago by buzz

  • reporter changed from buzz to human

  Changed 21 months ago by buzz

  • priority changed from major to critical

upgraded to critical

  Changed 21 months ago by buzz

  • status changed from accepted to closed
  • resolution set to fixed

This is now resolved in version 1.0.0.36, this will appear on wordpress svn shortly.

I have ported the salt function from project Cura for this purpose.

You can check out the current dev copy from :

svn export http://svn.saiweb.co.uk/branches/wordpress-flowplayer/flowplayer.php
Note: See TracTickets for help on using tickets.